Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[es] Create homepage for Spanish localization #4989

Merged
merged 10 commits into from
Aug 9, 2024

Conversation

theletterf
Copy link
Member

@theletterf theletterf commented Aug 7, 2024

Contributes to #4887.

Important points for discussion:

  • I chose to translate trace as traza, as its lexically closer than Google's own translation as seguimientos. It's also more common in Spanish blogs, I think.
  • SImilarly, I preferred to translate logs as logs, which is in line with Spanish Wikipedia and common usage in the industry. Registros is too generic and verbose.
  • Mentions of software have been translated to aplicación or aplicaciones.
  • Instrument is a tricky verb. There's no direct equivalent in Spanish, but I chose to go with instrumentar, as it's used already in technical documents.

Once we agreed on the usage of these words, we should set up a shared dictionary somewhere, for example in Google Drive.


Preview: https://deploy-preview-4989--opentelemetry.netlify.app/es/

@theletterf theletterf self-assigned this Aug 7, 2024
@theletterf theletterf requested a review from a team August 7, 2024 10:48
@theletterf
Copy link
Member Author

@mx-psi @krol3 Please have a look. Thanks!

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending removal of the REDIRECTS output specifier.

content/es/_index.md Outdated Show resolved Hide resolved
content/es/_index.md Outdated Show resolved Hide resolved
@chalin
Copy link
Contributor

chalin commented Aug 7, 2024

@theletterf - Question. Did you want to:

  • Update the Hugo config in this PR; or did you want me to do it?
  • How about enabling an es dictionary?

Co-authored-by: Patrice Chalin <[email protected]>
@theletterf
Copy link
Member Author

@chalin Thanks! Let me try that in this PR.

@opentelemetrybot opentelemetrybot requested a review from a team August 7, 2024 14:58
@theletterf
Copy link
Member Author

@chalin Followed the pattern of the pt-BR change, PTAL!

content/es/_index.md Outdated Show resolved Hide resolved
content/es/_index.md Outdated Show resolved Hide resolved
theletterf and others added 2 commits August 7, 2024 17:14
.cspell.yml Outdated Show resolved Hide resolved
hugo.yaml Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@chalin chalin self-requested a review August 7, 2024 16:56
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments, and fix the formatting issue. Otherwise LGTM once the comments are addressed and/or resolved. Thanks!

@theletterf theletterf requested review from ramrodo, mx-psi and krol3 August 8, 2024 06:49
@theletterf
Copy link
Member Author

@krol3 @ramrodo @mx-psi Please have a second look, especially focusing on the terminology points I put in the description of this PR. Thanks!

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The terminology used also seems idiomatic to me and in common use in technical writeups

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theletterf - you'll also need to setup mount points; see towards the end of this Hugo config file. Without them, no content will render:

image

@theletterf theletterf added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit cfa750d Aug 9, 2024
19 checks passed
@theletterf theletterf deleted the theletterf-initial-es-localization branch August 9, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants